Rewrite AxesStack independently of cbook.Stack. #22114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jan 5, 2022
AxesStack is fairly independent from cbook.Stack: cbook.Stack handles the forward/back/home buttons of the navbar, and therefore additionally maintains a movable "cursor" in the stack; AxesStack, on the other hand, needs to keep track both of "original" order and of "gca" order. Rewriting it from scratch, and using "original" order as main storage order (the "gca" stack being tracked using indices) shortens the implementation and simplifies it (as there's no more need to figure out what the super()calls do).
|
Thanks, all comments addressed. |
greglucas
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AxesStack is fairly independent from cbook.Stack: cbook.Stack handles
the forward/back/home buttons of the navbar, and therefore additionally
maintains a movable "cursor" in the stack; AxesStack, on the other hand,
needs to keep track both of "original" order and of "gca" order.
Rewriting it from scratch, and using "original" order as main storage
order (the "gca" stack being tracked using indices) shortens the
implementation and simplifies it (as there's no more need to figure out
what the super()calls do).
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).