Improve formatting of "Anatomy of a figure" #22206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
No visual change.
|
Maybe just include the static change here as well? Only change here I don't agree with is the extra brackets. I don't think they add much information at the expense of considerable clutter |
|
Still have to grab the static image from the doc build (too lazy to build locally). |
jklymak
approved these changes
Jan 14, 2022
- Adapt margins - Reduce figure border width (still thick but not massive) - fontfamily: make code monospace - slightly move annotations to better places
|
Note I intentionally reduced the size from 800px to 750px because 750 is the max-width in the pydata-sphinx-theme. 800px would be resampled by the browser. |
|
Is that hi dpi though? I think in the case where we have a static image we should always serve as hi dpi. Lo dpi plots look really bad on a 2x display. |
|
Yes, if you Check the image it‘s 1500 px. |
|
@meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 16, 2022
timhoffm
added a commit
that referenced
this pull request
Jan 17, 2022
…206-on-v3.5.x Backport PR #22206 on branch v3.5.x (Improve formatting of "Anatomy of a figure")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
()when it's a function