Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Docstrings for _qhull. #22342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Docstrings for _qhull. #22342

merged 1 commit into from
Jan 29, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 28, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

"Parameters\n"
"----------\n"
"x, y : 1d arrays\n"
" The coordinates of the point set, which must consist of at least \n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace, sort of:

Suggested change
" The coordinates of the point set, which must consist of at least \n"
" The coordinates of the point set, which must consist of at least\n"

@timhoffm
Copy link
Member

Is this rendered somewhere in the docs?

@anntzer
Copy link
Contributor Author

anntzer commented Jan 29, 2022

It's private and not rendered, but still useful if someone wants to check what these internal functions are doing (e.g., via pydoc or via ipython's ?).

@timhoffm timhoffm added this to the v3.6.0 milestone Jan 29, 2022
@timhoffm timhoffm merged commit dc1e9c1 into matplotlib:main Jan 29, 2022
@anntzer anntzer deleted the _qhull branch January 29, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants