Make signature of Axes.annotate() more explicit. #22388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6c1d4c to
03344dd
Compare
QuLogic
reviewed
Feb 4, 2022
jklymak
approved these changes
Feb 4, 2022
The signature is identical to Annotation. This makes the parameters explicit instead of `*args`, which improves usability. On the downside, this introduces redundancy. But we can bear that. The signature will not change often and I've added a test that ensures the signatures stay synchronized.
03344dd to
c4116bb
Compare
QuLogic
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature is identical to Annotation. This makes the parameters
explicit instead of
*args, which improves usability. On the downside,this introduces redundancy. But we can bear that. The signature will
not change often and I've added a test that ensures the signatures
stay synchronized.