[DOC]: Removed a redundant 'The' #22406
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thanks! We appreciate contributions of any size and kind. Documenattion fixes from people new to the project are particularly valuable as (at least I) tend to get "word blind" due to familiarity. While I agree that the wording now is not quite right, but I do no think dropping the "the" is the right fix. If were to drop the "Python scripts", the sentence would read
which also does not read quite right. Maybe
would read better? |
Honestly, in my opinion, it sounds better without "the": maybe I'm wrong |
Fair. I still do not agree, but not strongly enough to block merging, Our policy on documentation PRs is one person with commit rights agreeing it is an improvement to merge so I leave this to someone else to merge. The test failures here are unrelated and should be ignored (the py37 in linux is the coverage fork issue and the OSX failures are (I suspect) a gs version change issue). |
README.rst
Outdated
| @@ -51,7 +51,7 @@ Check out our `home page <https://matplotlib.org/>`_ for more information. | |||
|
|
|||
| Matplotlib produces publication-quality figures in a variety of hardcopy | |||
| formats and interactive environments across platforms. Matplotlib can be used | |||
| in Python scripts, the Python and IPython shell, web application servers, and | |||
| in Python scripts, Python and IPython shell, web application servers, and | |||
There was a problem hiding this comment.
I'd also go with:
| in Python scripts, Python and IPython shell, web application servers, and | |
| in Python scripts, the Python or IPython shells, web application servers, and |
|
Thanks @dSupertramp, and congratulations on your first contribution to Matplotlib! We hope to hear from you again. |
Thanks for the opportunity! |
Hi, this is my first pull request in an open source project.
I know it's not fair to write this kind of description here, but it's just a way for you to leave a message.
Advice is welcome, thank you!