Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Copy arrowprops argument to FancyAnnotationBbox. #22457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Feb 12, 2022

... so that we don't mutate dicts passed in by the user (we in fact pop
a key from arrowprops a bit later), and so that later mutations to the
dict from the user side don't affect the artist.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

... so that we don't mutate dicts passed in by the user (we in fact pop
a key from arrowprops a bit later), and so that later mutations to the
dict from the user side don't affect the artist.
@timhoffm timhoffm added this to the v3.6.0 milestone Feb 12, 2022
@timhoffm timhoffm merged commit 5f966f5 into matplotlib:main Feb 12, 2022
@anntzer anntzer deleted the abbc branch February 12, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants