Fix Radar Chart Gridlines for Non-Circular Charts #22458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
anntzer
approved these changes
Feb 13, 2022
|
Thanks, this looks great! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 13, 2022
This was referenced Feb 13, 2022
Merged
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 13, 2022
6 tasks
timhoffm
added a commit
that referenced
this pull request
Feb 13, 2022
…458-on-v3.5.x Backport PR #22458 on branch v3.5.x (Fix Radar Chart Gridlines for Non-Circular Charts)
timhoffm
added a commit
that referenced
this pull request
Feb 13, 2022
…458-on-v3.5.1-doc Backport PR #22458 on branch v3.5.1-doc (Fix Radar Chart Gridlines for Non-Circular Charts)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the gridlines for non-circular radar charts. This fixes #19981. Starting with version 3.3.0 the autoconversion to circular arcs in PolarAxes.PolarTransform forced all gridlines to be circular. This PR provides the necessary changes in the example for radar charts to produce gridlines of the same shape as the frame.
Many thanks to @anntzer for identifying the cause of the problem and distilling the proposed fix to a minimal solution.