Prepare for making create_dummy_axis not necessary. #22554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_dummy_axis() sets up some internal _DummyAxis, which should not really have been leaked to end users; instead, we should just always attach a _DummyAxis to locators and formatters at init to start with. _DummyAxis should actually be quite cheap to create, but it does create two Bbox.unit() (dataLim and viewLim) which are *slightly* expensive to create, can be placed by plain tuples, and do not correspond to any APIs on "standard" Axises (there's Axes.dataLim/viewLim, not Axis.dataLim/viewLim). While the offending attributes are on a private class, they are publically accessible e.g. via `locator.create_dummy_axis(); locator.axis` so go through a deprecation to be extra safe.
oscargus
approved these changes
Mar 1, 2022
timhoffm
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_dummy_axis() sets up some internal _DummyAxis, which should not
really have been leaked to end users; instead, we should just always
attach a _DummyAxis to locators and formatters at init to start with.
_DummyAxis should actually be quite cheap to create, but it does create
two Bbox.unit() (dataLim and viewLim) which are slightly expensive to
create, can be placed by plain tuples, and do not correspond to any APIs
on "standard" Axises (there's Axes.dataLim/viewLim, not
Axis.dataLim/viewLim). While the offending attributes are on a private
class, they are publically accessible e.g. via
locator.create_dummy_axis(); locator.axisso go through a deprecationto be extra safe.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).