MNT: Fix types in C-code to reduce warnings #22604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Mar 4, 2022
QuLogic
reviewed
Mar 4, 2022
5ad5aee to
b38f5b8
Compare
|
Turned out that MSVC does not consider snprintf as a safe function either, but I think it can stay to avoid an extra build cycle (if the rest is OK) and that it probably is safer than sprintf anyway. |
timhoffm
approved these changes
Mar 5, 2022
QuLogic
reviewed
Mar 7, 2022
| @@ -291,7 +291,7 @@ static unsigned long read_from_file_callback(FT_Stream stream, | |||
| return 1; // Non-zero signals error, when count == 0. | |||
| } | |||
| } | |||
| return n_read; | |||
| return PyLong_AsUnsignedLong(PyLong_FromSsize_t(n_read)); | |||
There was a problem hiding this comment.
This change is new from after I reviewed; it leaks the PyLong you just created. Anyway, I don't know why you need a PyLong and can't just cast it in C++?
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 14, 2022
1 task
anntzer
reviewed
Mar 15, 2022
| @@ -1545,7 +1545,7 @@ PyMODINIT_FUNC PyInit_ft2font(void) | |||
| FT_Int major, minor, patch; | |||
| char version_string[64]; | |||
| FT_Library_Version(_ft2Library, &major, &minor, &patch); | |||
| sprintf(version_string, "%d.%d.%d", major, minor, patch); | |||
| snprintf(version_string, sizeof(version_string), "%d.%d.%d", major, minor, patch); | |||
There was a problem hiding this comment.
This could have been PyOS_snprintf for consistency with the rest of the codebase.
There was a problem hiding this comment.
OK! It still complains, so can change it.
oscargus
added a commit
that referenced
this pull request
Mar 15, 2022
Fix new leak in ft2font introduced in #22604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Minor fix getting rid of type cast warnings (on Windows).
(Editor removed some trailing spaces.)
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).