Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: Flush events after closing figures in macosx backend #22644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

greglucas
Copy link
Contributor

PR Summary

Closing a window would keep the window around with a spinning ball. If we flush the pending events, the window can close immediately.

import numpy as np
import matplotlib.pyplot as plt
import time

x = np.arange(5)
y = np.arange(5)

plt.plot(x, y)
plt.show()

time.sleep(5)

This will need to be tested manually. I'm not sure how we would be able to test it otherwise.

Closes #11861

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@greglucas greglucas added this to the v3.6.0 milestone Mar 13, 2022
@oscargus oscargus merged commit 5295e9a into matplotlib:main Mar 14, 2022
@greglucas greglucas deleted the macosx-close-figure branch March 14, 2022 14:23
@greglucas
Copy link
Contributor Author

I am hopeful that one of you had a mac to test this on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure does not close until script finishes execution
3 participants