Update deprecated vmImage 'vs2017-win2016' in azure pipelines #22670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's actually that I moved the 3.7 section to the end and changed it to 3.10. Really, I think 3.8 maybe should've had the oldest version, but I'm not sure if it really matters, so long as somewhere is checking old builds. It's probably fine to make it latest. |
3eeedcf to
0e5eb35
Compare
0e5eb35 to
093b6cf
Compare
|
Ok, I've pinned the win_py38 build to |
tacaswell
approved these changes
Mar 22, 2022
QuLogic
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/#windows says that 'vs2017-win2016' will likely work with 'windows-2019' as well.
This changes from VisualStudio 2017 to VisualStudio 2019. Not sure if that's a problem. Lets's see.
N.b. 'windows-2019' is the same as 'windows-latest', and the py38 and py39 builds use the latter. Is there a reason that we pin the version here?