Fix path_effects to work on text with spaces only #22689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a line of text contains no visual output (spaces only or empty newlines), there is no path to create for the effects. So, the data array for this non-path does not have the commonly expected shape for a path, so the logic bails with an error. The solution is, do not try to draw a path when the text string has only spaces and newlines. closes matplotlib#22687
|
I could also see a case for adjusting the shape check farther down to make 0 length paths pass. |
timhoffm
approved these changes
Mar 24, 2022
I went for a real empty path. I was afraid that blow up elsewhere, but it has worked! |
oscargus
approved these changes
Mar 24, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 25, 2022
timhoffm
added a commit
that referenced
this pull request
Mar 25, 2022
…689-on-v3.5.x Backport PR #22689 on branch v3.5.x (Fix path_effects to work on text with spaces only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a line of text contains no visual output (spaces only or empty
newlines), there is no path to create for the effects. So, the data
array for this non-path does not have the commonly expected shape for a
path, so the logic bails with an error.
The solution is, do not try to draw a path when the text string has
only spaces and newlines.
closes #22687
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).