FIX: remove toggle on QuadMesh cursor data #22691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e17643 to
38744e0
Compare
tacaswell
reviewed
Mar 23, 2022
| @@ -0,0 +1,4 @@ | |||
| QuadMesh cursor data removed | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| `.QuadMesh.get_cursor_data`, introduced in 3.5.1 is unreasonably slow for | |||
There was a problem hiding this comment.
Suggested change
| `.QuadMesh.get_cursor_data`, introduced in 3.5.1 is unreasonably slow for | |
| `.QuadMesh.get_cursor_data`, introduced in 3.5 is unreasonably slow for |
6 tasks
|
#22693 works for me; can you confirm? |
38744e0 to
6c2de24
Compare
6c2de24 to
c784dc0
Compare
anntzer
reviewed
Mar 24, 2022
anntzer
approved these changes
Mar 24, 2022
c784dc0 to
8971f1d
Compare
tacaswell
approved these changes
Mar 24, 2022
|
Something seems off with meeseeks. |
|
@meeseeksdev backport to v3.5.x For some reason, it thought this was closed and not merged. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 25, 2022
tacaswell
added a commit
that referenced
this pull request
Mar 29, 2022
…691-on-v3.5.x Backport PR #22691 on branch v3.5.x (FIX: remove toggle on QuadMesh cursor data)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update:
Closes #22694
Follows up on #22693
Removes ineffective toggle for cursor data, and updates usage note to point out that mouseover is set to False by default. It is possible we will want more documentation of this as per @timhoffm
Old:
Closes #22520
#19908 made using a mouse over large pcolormesh unusably slow.
#22254 attempted to make this togglable with short circuit.
Despite the changes in #22254, pcolormesh is still really slow if you try and move a mouse around. I actually do not understand why this is the case, because the short circuit in #22254 is actually called. However, I'll put the onus of understanding the problem on the folks who want the cursor data, and I think we should pull this out for now.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).