Doc tweak transform tutorial #22702
Merged
Doc tweak transform tutorial #22702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extended the headers - moved "display" to the bottom - add notes about "display" coordinates being backend dependent
Try to make it more clear that the transforms are naive-to-coordinates functions and the naming conventions / always go to display convention is to aid understanding but not inherent to the code.
jklymak
reviewed
Mar 28, 2022
Comment on lines
24
to
26
| |"data" |The coordinate system for the data,|``ax.transData`` | | ||
| | |controlled by xlim and ylim. | | | ||
| +----------------+-----------------------------------+-----------------------------+ |
There was a problem hiding this comment.
Suggested change
| |"data" |The coordinate system for the data,|``ax.transData`` | | |
| | |controlled by xlim and ylim. | | | |
| +----------------+-----------------------------------+-----------------------------+ | |
| |"data" |The axes coordinate system for the data,|``ax.transData`` | | |
| | |controlled by xlim and ylim. | | | |
| +----------------+-----------------------------------+-----------------------------+ |
There was a problem hiding this comment.
I would say 'The coordinate system for the data in an Axes'
Comment on lines
79
to
80
| The transformations also know how to invert themselves, to go from *display* | ||
| back to the native coordinate system. This is particularly useful when |
There was a problem hiding this comment.
Suggested change
| The transformations also know how to invert themselves, to go from *display* | |
| back to the native coordinate system. This is particularly useful when | |
| The transformations also know how to invert themselves, to go from *display* | |
| back to the transform's coordinate system. This is particularly useful when |
not sure this is right, but "native" isn't fully clear here...
There was a problem hiding this comment.
back to the input coordinate system?
QuLogic
reviewed
Mar 30, 2022
Comment on lines
24
to
26
| |"data" |The coordinate system for the data,|``ax.transData`` | | ||
| | |controlled by xlim and ylim. | | | ||
| +----------------+-----------------------------------+-----------------------------+ |
There was a problem hiding this comment.
I would say 'The coordinate system for the data in an Axes'
| available to you, or create your own (see :mod:`matplotlib.transforms`). The | ||
| table below summarizes the some useful coordinate systems, the description of | ||
| that system, and the transformation object for going from that coordinate | ||
| system to the *display* coordinates. In the ``Transformation Object`` column, | ||
| ``ax`` is a :class:`~matplotlib.axes.Axes` instance, and ``fig`` is a | ||
| :class:`~matplotlib.figure.Figure` instance. |
There was a problem hiding this comment.
We missed defining subfigure before.
Comment on lines
79
to
80
| The transformations also know how to invert themselves, to go from *display* | ||
| back to the native coordinate system. This is particularly useful when |
There was a problem hiding this comment.
back to the input coordinate system?
|
Moved to draft for now |
Co-authored-by: Elliott Sales de Andrade <[email protected]> Co-authored-by: Jody Klymak <[email protected]>
|
Directly took about half of the coments and tried to address the rest. |
jklymak
approved these changes
Apr 9, 2022
|
Lets merge as an improvement. If there are further suggestions, they can come in a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
I tried to clarify some of the transform tutorial prose based on #22688 (comment)
PR Checklist
Documentation