Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix incorrect deprecation warning #22719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Fix incorrect deprecation warning #22719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/matplotlib/category.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def convert(value, unit, axis):
is_numlike = all(units.ConversionInterface.is_numlike(v)
and not isinstance(v, (str, bytes))
for v in values)
if is_numlike:
if values.size and is_numlike:
_api.warn_deprecated(
"3.5", message="Support for passing numbers through unit "
"converters is deprecated since %(since)s and support will be "
Expand Down Expand Up @@ -230,7 +230,7 @@ def update(self, data):
convertible = self._str_is_convertible(val)
if val not in self._mapping:
self._mapping[val] = next(self._counter)
if convertible:
if data.size and convertible:
_log.info('Using categorical units to plot a list of strings '
'that are all parsable as floats or dates. If these '
'strings should be plotted as numbers, cast to the '
Expand Down
9 changes: 9 additions & 0 deletions lib/matplotlib/tests/test_category.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,15 @@ def test_overriding_units_in_plot(fig_test, fig_ref):
assert y_units is ax.yaxis.units


def test_no_deprecation_on_empty_data():
"""
Smoke test to check that no deprecation warning is emitted. See #22640.
"""
f, ax = plt.subplots()
ax.xaxis.update_units(["a", "b"])
ax.plot([], [])


def test_hist():
fig, ax = plt.subplots()
n, bins, patches = ax.hist(['a', 'b', 'a', 'c', 'ff'])
Expand Down