Use system distutils instead of the setuptools copy #22756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0dc232c to
f5ab2e5
Compare
|
setuptools-59.8.0 worked; going to try something from 60. now. |
cf8d106 to
ae0274f
Compare
|
And setuptools-60.10.0 fails. |
0e74630 to
8bd52b0
Compare
|
Dropping down to 60.0.0 fails as well, and the main change there is switching to setuptools' internal copy of distutils. |
|
cibuildwheel is pinned to setuptools 56, though AppVeyor is on 61.3.0. Not sure I should set the env var on the former too, but maybe we'll just wait until an update allows installing a newer version. |
oscargus
approved these changes
Apr 1, 2022
|
Do we need to document this in the install instructions as well? I'm going to merge this to un-break CI. |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 1, 2022
This was referenced Apr 1, 2022
oscargus
added a commit
that referenced
this pull request
Apr 4, 2022
…756-on-v3.5.x Backport PR #22756 on branch v3.5.x (Use system distutils instead of the setuptools copy)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
setuptools 60 re-enabled their local copy of
distutils: pypa/setuptools#2896This apparently fails to set up paths that can find
msbuild, so switch back the standard librarydistutils.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).