Backport PR #22732: FIX: maybe improve renderer dance #22783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request matplotlib#22732 from jklymak/fix-renderer-dance FIX: improve cached renderer dance (cherry picked from commit 9e0eb54) The changes had to be moved to figure.py due to a major refactoring that will be released in 3.6 that is already on main.
|
This should be reviewed carefully because it is essentially a different patch than in #22783 due to code having moved around. |
|
@tacaswell I took the liberty of pushing a typo fix to your branch.... |
|
I manually tested the two cases again import matplotlib.pyplot as plt
plt.rcParams['figure.autolayout'] = 'True'
plt.plot([1, 2, 3], [1, 2, 3], 'o-')
plt.title(r'$\sum_{i=0}^{\infty} x_i$ just a test')
plt.savefig('/tmp/test2.eps', format='eps')(interactively) from matplotlib import pylab as plt
plt.rcParams['savefig.format'] = 'pdf'
plt.ion()
fig, ax = plt.subplots()
ax.plot([0,1])
fig.tight_layout()
and both appear to work. |
|
I may have jumped the gun on merging this, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pull request #22732 from jklymak/fix-renderer-dance
FIX: improve cached renderer dance
(cherry picked from commit 9e0eb54)
The changes had to be moved to figure.py due to a major refactoring that will
be released in 3.6 that is already on main.