Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use bool for bool keyword arguments #22821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Use bool for bool keyword arguments #22821

merged 1 commit into from
Apr 11, 2022

Conversation

oscargus
Copy link
Member

PR Summary

Some examples use 0 or 1 for bool arguments. While this works, it probably is more correct to actually use bools as it is more clear that this is a bool, not an integer.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much clearer - the #s w/ these names make it seem like these are numeric keywords

@story645 story645 merged commit 25c85f0 into main Apr 11, 2022
@story645 story645 deleted the minorfixes branch April 11, 2022 14:53
@tacaswell tacaswell added this to the v3.6.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants