Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small cleanups to mathtext. #22877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2022
Merged

Small cleanups to mathtext. #22877

merged 1 commit into from
Apr 22, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 21, 2022

  • Don't return fontsize from _get_glyph anymore, as the value is always
    unmodified from the passed-in value.
  • Rename fname to family (it is not a filename, which is what
    fname usually means).
  • List mathtext commands using raw strings.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

QuLogic
QuLogic approved these changes Apr 22, 2022
View reviewed changes
@anntzer
Small cleanups to mathtext.
9e80fdd 
- Don't return fontsize from _get_glyph anymore, as the value is always
  unmodified from the passed-in value.
- Rename `fname` to `family` (it is not a filename, which is what
  `fname` usually means).
- List mathtext commands using raw strings.
@anntzer anntzer force-pushed the moremathtextcleanup branch from ffca257 to 9e80fdd Compare April 22, 2022 11:19
@timhoffm timhoffm merged commit e077394 into matplotlib:main Apr 22, 2022
@timhoffm timhoffm added this to the v3.6.0 milestone Apr 22, 2022
@anntzer anntzer deleted the moremathtextcleanup branch April 22, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/mathtext
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm