Missing f prefix on f-strings fix
#22884
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
I have mixed feelings about PRs from bots (?) but this fix is correct and I see no reason not to take it. |
|
May be better to merge #22883 though. |
|
The problem is not in 3.5.2 so I changed to 3.6 for this, which leads to closing this and merging #22883 instead. |
|
@tacaswell I'm really a person that found a bug via a static analysis bot I wrote. FWIW I checked 666 of the most popular python repos on GitHub and found 73 repos that had this issue. I then ran my script that auto-creates the issues in GitHub then auto-creates the PR to fix the issues. Half bot half human I guess :) |
|
@code-review-doctor Sorry, when I clicked through the profile I jumped to conclusions 🐑 This found a real bug and even though we fixed it differently, we appreciate the PR and hope to hear from you again! |
Fixes #22882