Fixed _upcast_err docstring and comments in _axes.py #22923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Apr 29, 2022
tacaswell
reviewed
Apr 29, 2022
011b318 to
c329972
Compare
|
@tacaswell I pushed updates to address your comments. I saw #21901 was tagged as 3.5.2 and had been dormant for a while. I only realized that it was assigned to you after I had already made my changes. I hope it is okay that I worked on this. |
c329972 to
ffae9de
Compare
tacaswell
reviewed
Apr 29, 2022
I do not mind at all! |
ffae9de to
439dbbe
Compare
tacaswell
approved these changes
Apr 29, 2022
I think it's better to correct it right now instead of needing to fix it later! |
|
meeseeksdev backport to v3.5.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 30, 2022
QuLogic
added a commit
that referenced
this pull request
Apr 30, 2022
…923-on-v3.5.x Backport PR #22923 on branch v3.5.x (Fixed _upcast_err docstring and comments in _axes.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses @efiring's concerns about the docstring and comments in #21884 (issue #21901).
Closes #21901
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).