Fix some possible encoding issues for non-utf8 systems. #23022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
read_text/write_text default to the locale encoding, which may or may not be utf8. Fix these by making the encoding explicit or by using bytes.
timhoffm
approved these changes
May 10, 2022
oscargus
approved these changes
May 10, 2022
QuLogic
reviewed
May 10, 2022
| @@ -15,6 +15,7 @@ | |||
| This creates in the build directory a file ``build/html/topic/old-page.html`` | |||
| that contains a relative refresh:: | |||
|
|
|||
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> | |||
There was a problem hiding this comment.
The meta tag should be in the head tag, not top-level.
There was a problem hiding this comment.
Oopsie. I don't claim any understanding of the html standard; do you know the correct syntax to make this interact with the other meta tag?
There was a problem hiding this comment.
They're independent, it just needs to be moved down, but also could be charset instead of a content-type: #23030
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_text/write_text default to the locale encoding, which may or may
not be utf8 (see #23019). Fix these by making the encoding explicit or by using
bytes.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).