Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Small cleanups to QuiverKey. #23119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2022
Merged

Small cleanups to QuiverKey. #23119

merged 1 commit into from
Nov 1, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 24, 2022

  • Text already calls FontProperties._from_any on anything passed as
    fontproperties; no need to do it ourselves again.
  • Group together x and y shifts for text positioning.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@jklymak jklymak marked this pull request as draft May 24, 2022 07:44
@jklymak
Copy link
Member

jklymak commented May 24, 2022

I've moved this to draft until #23116 to prevent a new contributor from having to rebase because of a cleanup.

@anntzer
Copy link
Contributor Author

anntzer commented May 24, 2022

I don't think these actually conflict, but sure, no hurries.

@anntzer
Small cleanups to QuiverKey.
16c67c8 
- Text already calls FontProperties._from_any on anything passed as
  fontproperties; no need to do it ourselves again.
- Group together x and y shifts for text positioning.
@anntzer anntzer marked this pull request as ready for review October 31, 2022 20:08
@anntzer
Copy link
Contributor Author

anntzer commented Oct 31, 2022

Actually to the best I can see this doesn't collide with #23116 at all.

@QuLogic
Copy link
Member

QuLogic commented Nov 1, 2022

I agree.

@QuLogic QuLogic merged commit e71827a into matplotlib:main Nov 1, 2022
@anntzer anntzer deleted the qk branch November 1, 2022 08:33
@QuLogic QuLogic added this to the v3.7.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
Maintenance status: waiting for other PR topic: arrow
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@anntzer @jklymak @QuLogic @timhoffm @oscargus