DOC: Migrate to sphinx-design #23169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former has been deprecated for the latter.
jklymak
approved these changes
May 31, 2022
|
Looks good to me as well, but will leave merging until more people have had a chance to take a look. |
timhoffm
approved these changes
May 31, 2022
There was a problem hiding this comment.
Comparison:
Front page panels
- https://output.circle-artifacts.com/output/job/143ebf07-1a9a-46c3-b256-99c5f38571b2/artifacts/0/doc/build/html/index.html
- https://matplotlib.org/devdocs/
Contributing buttons
- https://output.circle-artifacts.com/output/job/143ebf07-1a9a-46c3-b256-99c5f38571b2/artifacts/0/doc/build/html/devel/index.html
- https://matplotlib.org/devdocs/devel/index.html
--> looks good.
QuLogic
added a commit
to QuLogic/mpl-sphinx-theme
that referenced
this pull request
Jun 21, 2022
QuLogic
added a commit
to QuLogic/mpl-sphinx-theme
that referenced
this pull request
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
sphinx-design is replacing sphinx-panels, reduces the amount of custom CSS we have, and is responsive. I have 2 column layout switch to single column at the 'small' transition (768px).
Though there are a few CSS tweaking classes we could apply to get things closer if we wish, I did not try to exactly match the existing layout.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).