Add tests for pan #23197
Merged
Add tests for pan #23197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce963de to
78d321f
Compare
greglucas
approved these changes
Jun 5, 2022
oscargus
commented
Jun 5, 2022
| tb.press_pan(start_event) | ||
| tb.drag_pan(stop_event) | ||
| tb.release_pan(stop_event) | ||
| print(ax.get_xlim()) |
There was a problem hiding this comment.
I should get rid of these... (Although they only print on errors...)
There was a problem hiding this comment.
does that get incorporated into the error message printed by the assert?
There was a problem hiding this comment.
Sort of. If the test fails, anything on stdout will be shown under a "Captured stdout" or something similar heading. (I used this to get the actual values for the test...).
story645
approved these changes
Jun 9, 2022
|
All the test failures are the font test. I am merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Panning was very scarcely tested.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).