Honour panchor keyword for colorbar on subplot
#23203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
approved these changes
Jun 4, 2022
jklymak
reviewed
Jun 5, 2022
| assert ax.get_anchor() == 'N' | ||
|
|
||
|
|
||
| def test_colorbar_single_ax_panchor_east(): |
There was a problem hiding this comment.
Can we test this with constrained_layout as well?
timhoffm
approved these changes
Jun 10, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 10, 2022
oscargus
added a commit
that referenced
this pull request
Jun 11, 2022
…203-on-v3.5.x Backport PR #23203 on branch v3.5.x (Honour `panchor` keyword for colorbar on subplot)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #23157. Also added a test for the case where
panchoris set to something different to the existing anchor setting on the main axes. Both tests fail without the change in the main code.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).