Default stem marker color follows the linecolor #23233
Conversation
|
Can you pass Context: #23230 (not sure if this is a consequence of this PR or a coincident) |
|
Will check that. Part of the problem is that currently markerstyle is just uses regular plot logic and if given e.g. 'r' that would be a red line connecting the points. IMHO we need special logic for markerstyle, which reflects the needs of stem. This PR does that and the "r" and "" issues would need a similar special handling. |
|
When I thought about this yesterday, I was contemplating providing the options that are set at the end of That together with replacing |
495e76d to
f02a3f3
Compare
f02a3f3 to
549054f
Compare
instead of the hard-coded 'C0'. While this is technically a breaking API change, it is unlikely that somebody wants to color their lines, but intentionally leaves their marker color as default 'C0'. I think there is no simple mechanism that'd allow a deprecation. All I can think of would require user actions at the beginning and at the end of the deprecation period. Given that this should only affect very few users and there is a simple workaround (state both formats explicitly).
549054f to
203cf26
Compare
PR Summary
This builds on top of #23232.If stem markerfmt does not contain a color, use the color from linefmt
instead of the hard-coded 'C0'. While this is technically a breaking
API change, it is unlikely that somebody wants to color their lines,
but intentionally leaves their marker color as default 'C0'. I think
there is no simple mechanism that'd allow a deprecation. All I can
think of would require user actions at the beginning and at the end
of the deprecation period. Given that this should only affect very
few users and there is a simple workaround (state both format explitly).