Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support inverted parentheses in mathtext. #23247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2022
Merged

Support inverted parentheses in mathtext. #23247

merged 1 commit into from
Jun 15, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 11, 2022 •
edited
Loading

TeX is perfectly happy to start with a closing parenthesis and end with
an opening one; no need to distinguish them.

Also fix a bug with old pyparsing versions for empty \left\right
blocks.

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

oscargus
oscargus approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to the failing test. (That is, I support the general "feature" and the implementation, except that it doesn't seem to work for the minimum version test.)

@anntzer
Copy link
Contributor Author

anntzer commented Jun 11, 2022

Ah, I ran into pyparsing/pyparsing@6a899ff. Now worked around as well (as we can't require pyparsing 3 yet).

@anntzer
Support inverted parentheses in mathtext.
1231898 
TeX is perfectly happy to start with a closing parenthesis and end with
an opening one; no need to distinguish them.

Also fix a bug with old pyparsing versions for empty `\left\right`
blocks.
@timhoffm timhoffm added this to the v3.6.0 milestone Jun 15, 2022
@timhoffm timhoffm merged commit a1747a5 into matplotlib:main Jun 15, 2022
@anntzer anntzer deleted the delims branch June 15, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
topic: text/mathtext
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @timhoffm @oscargus @QuLogic