Cleanup FontProperties examples. #23322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unpyplot the examples; assigning the results to "t" doesn't really say anything (this would be different if the example was about text objects); other style fixes. - In the OO example, instead of mutating a global FontProperties, create one locally and set the properties on it. (Even better would be to just do `font = Fontproperties(prop=...)`, but `FontProperties(family="sans-serif")` currently fails due to confusion between the family kwarg and fontconfig patterns...) - x-large bold italic was misplaced in the OO example -- compare with the kwargs example.
timhoffm
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anything (this would be different if the example was about text
objects); other style fixes.
one locally and set the properties on it. (Even better would be to
just do
font = Fontproperties(prop=...), butFontProperties(family="sans-serif")currently fails due to confusionbetween the family kwarg and fontconfig patterns... Various issues with FontProperties #10249)
the kwargs example.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).