Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix errorbar handling of nan. #23333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fix errorbar handling of nan. #23333

merged 1 commit into from
Jun 24, 2022

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 23, 2022

PR Summary

Closes #23330. Fixes a regression, so let's mark this as RC?

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 23, 2022
@anntzer anntzer added this to the v3.5.3 milestone Jun 23, 2022
@tacaswell tacaswell merged commit a2ad1f7 into matplotlib:main Jun 24, 2022
@tacaswell
Copy link
Member

Merging over the font failures which we understand.

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 24, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 a2ad1f7a036be86b089faf1db4c9528d0d93f018
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23333: Fix errorbar handling of nan.'
  1. Push to a named branch:
git push YOURFORK v3.5.x:auto-backport-of-pr-23333-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR #23333 on branch v3.5.x (Fix errorbar handling of nan.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the en branch June 24, 2022 22:12
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jun 24, 2022
Merge pull request matplotlib#23333 from anntzer/en

Fix errorbar handling of nan.

(cherry picked from commit a2ad1f7)

Conflicts:
        lib/matplotlib/axes/_axes.py
                Other min -> manmin type changes on main
QuLogic added a commit that referenced this pull request Jun 25, 2022
…-v3.5.x

Backport PR #23333: Fix errorbar handling of nan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing values cause exception in errorbar plot
3 participants