Simplify/improve check for pycairo in Gtk-based backends. #23347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gtk-based backends require pycairo (cairocffi is unsupported: https://pygobject.readthedocs.io/en/latest/guide/cairo_integration.html). Prior to this patch, trying to run gtk{3,4}{agg,cairo} fails *at draw time* `TypeError: Couldn't find foreign struct converter for 'cairo.Context'`). This patch moves the import check for cairo to the top of the common _backend_gtk, and also simplifies backend_gtk{3,4}agg to always use pycairo (in which case backend_cairo._to_context is a no-op) as they cannot inter-operate with cairocffi anyways.
tacaswell
approved these changes
Jun 25, 2022
timhoffm
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gtk-based backends require pycairo (cairocffi is unsupported:
https://pygobject.readthedocs.io/en/latest/guide/cairo_integration.html).
Prior to this patch, trying to run gtk{3,4}{agg,cairo} fails at draw
time
TypeError: Couldn't find foreign struct converter for 'cairo.Context').This patch moves the import check for cairo to the top of the common
_backend_gtk, and also simplifies backend_gtk{3,4}agg to always use
pycairo (in which case backend_cairo._to_context is a no-op) as they
cannot inter-operate with cairocffi anyways.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).