Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename/change signature of PyGlyph_new. #23364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 29, 2022

Unlike all other ExtensionType_new functions, PyGlyph_new is not a
tp_new (https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_new)
but simply a plain C function used to construct a struct from the fields
of a FT2Font. Rename it to avoid confusion, and make it take a single
FT2Font as argument, too (with some additional fixes for
const-correctness).

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Unlike all other ExtensionType_new functions, PyGlyph_new is not a
tp_new (https://docs.python.org/3/c-api/typeobj.html#c.PyTypeObject.tp_new)
but simply a plain C function used to construct a struct from the fields
of a FT2Font.  Rename it to avoid confusion, and make it take a single
FT2Font as argument, too (with some additional fixes for
const-correctness).
@QuLogic QuLogic added this to the v3.6.0 milestone Jun 29, 2022
@QuLogic QuLogic merged commit 246b6a0 into matplotlib:main Jun 29, 2022
@anntzer anntzer deleted the pgn branch June 29, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants