Fix pan/zoom crashing when widget lock is unavailable #23373
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
496de36 to
1983571
Compare
|
I was able to test the fix in jupyter-notebook, and it works fine. see: #23324 (comment) Thanks ! |
| @@ -175,6 +175,18 @@ def test_interactive_zoom(): | |||
| assert not ax.get_autoscalex_on() and not ax.get_autoscaley_on() | |||
|
|
|||
|
|
|||
| # GH #23324 | |||
There was a problem hiding this comment.
| # GH #23324 |
1983571 to
fd99fb8
Compare
|
Congratulations on your first Matplotlib contribution @kianelbo and thank you very much! Hope to see you around! |
PR Summary
Closes #23324
To fix the crash, when toggling zoom or pan tools, first check if widgetlock is available to proceed.
Btw, I only could test it with MACOSX backend and it was ok.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).