Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add conda env to setup instructions #23435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

acatlett8
Copy link
Contributor

PR Summary

#21611

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [ X] Documentation is sphinx and numpydoc compliant (the docs should build without error).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@QuLogic QuLogic added Documentation mentored: sprint Issues intended and suitable for sprints labels Jul 16, 2022
Comment on lines +20 to +22
If you have the proper privileges, you can use ``git@`` instead of
``https://``, which works through the ssh protocol and might be easier to use
if you are using 2-factor authentication.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you have the proper privileges, you can use ``git@`` instead of
``https://``, which works through the ssh protocol and might be easier to use
if you are using 2-factor authentication.

No one should be pushing directly to the upstream fork (even if they can) as we do all work through PRs from individual forks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put that change into #23588?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 4, 2022
@tacaswell
Copy link
Member

I am 👍🏻 on this modulo my comment.

@tacaswell
Copy link
Member

@melissawm I am going to apologize in advance for causing you rebase-of-prose issues.

@tacaswell tacaswell merged commit ecab6de into matplotlib:main Aug 10, 2022
@tacaswell
Copy link
Member

Congratulations @acatlett8 on your first merged Matplotlib PR 🎉 Hopefully we will hear from you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation mentored: sprint Issues intended and suitable for sprints
Projects
Development

Successfully merging this pull request may close these issues.

3 participants