Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add markerfacealt to pass-through arguments for error bar lines #23475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 1, 2022
Merged

Add markerfacealt to pass-through arguments for error bar lines #23475

merged 5 commits into from
Aug 1, 2022

Conversation

wqian94
Copy link
Contributor

@wqian94 wqian94 commented Jul 22, 2022 •
edited
Loading

PR Summary

Add markerfacealt as a line kwarg that should be passed through when making error bars. See issue #23375

PR Checklist

Tests and Styling

  • [✔️] Has pytest style unit tests (and pytest passes).
  • [✔️] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [✔️] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [✔️] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@wqian94 wqian94 marked this pull request as ready for review July 23, 2022 17:13
@wqian94 wqian94 mentioned this pull request Jul 23, 2022
Closed
timhoffm
timhoffm approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo a formatting issue.

@wqian94 @timhoffm
Update lib/matplotlib/axes/_axes.py
3e4810a 
Fix tabbing on documentation

Co-authored-by: Tim Hoffmann <[email protected]>
@oscargus oscargus added this to the v3.6.0 milestone Aug 1, 2022
@oscargus oscargus merged commit a01a1df into matplotlib:main Aug 1, 2022
@oscargus
Copy link
Member

oscargus commented Aug 1, 2022

Thanks and congratulations on your first merged PR @wqian94 ! Hope to see you around!

@oscargus oscargus mentioned this pull request Aug 1, 2022
Closed
@wqian94
Copy link
Contributor Author

wqian94 commented Aug 1, 2022

Thanks!

@QuLogic QuLogic mentioned this pull request Sep 9, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@oscargus oscargus oscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wqian94 @oscargus @timhoffm