Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mathtext spaces must be independent of font style. #23482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

tfpf
Copy link
Contributor

@tfpf tfpf commented Jul 23, 2022

PR Summary

Fixes #23474.
before

The width of the space inserted by, for instance, \, and \mathrm{\,}, is now the same.
after

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@tfpf tfpf marked this pull request as ready for review July 23, 2022 06:04
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See rationale at #23474 (comment): maybe not the absolutely correct solution, but certainly the most practical one.

@tfpf tfpf force-pushed the consistent-spacing branch from 2322e05 to 686dffa Compare July 25, 2022 09:16
@QuLogic QuLogic added this to the v3.6.0 milestone Jul 26, 2022
@QuLogic QuLogic merged commit 5fc0441 into matplotlib:main Jul 26, 2022
@tfpf tfpf deleted the consistent-spacing branch July 26, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: \, and \mathrm{\,} are not identical in Mathtext when using CM and STIX
3 participants