supporting IBM i OS #23511
Merged
supporting IBM i OS #23511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Are you aware of any way to test this? That is, any (free) CI service where one can run IBM i OS (and/or AIX)? (Did a quick googling, but didn't find anything.) |
greglucas
reviewed
Jul 29, 2022
|
Historically we have taken these special cases to the build scripts without worrying about tests due to the lack of CI infrastructure. They tend to be opened by people who do have these systems and so long as the changes do not affect the more common platforms there is no downside to carrying the patches upstream. |
Co-authored-by: Greg Lucas <[email protected]>
tacaswell
approved these changes
Jul 29, 2022
QuLogic
approved these changes
Jul 29, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 29, 2022
|
Thank you @GavinGZhang ! |
QuLogic
added a commit
that referenced
this pull request
Jul 29, 2022
…511-on-v3.5.x Backport PR #23511 on branch v3.5.x (supporting IBM i OS)
|
Thanks for your such a quick response. Yes, we would make sure it works on our IBM i system. We would also make sure the code would not do any harm to other platforms. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is to make it support IBM i OS.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).