Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tests for sankey and minor fixes #23533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

oscargus
Copy link
Member

@oscargus oscargus commented Aug 1, 2022

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@tacaswell
Copy link
Member

tacaswell commented Aug 1, 2022

I think not var is both clearer and more idiomatic than var is False (I started to put in suggested edits on them, but gave up after 2). not var handles anything that will cast though bool (rather than being exactly the False object).

@tacaswell
Copy link
Member

Never mind, I take back my comment. These are internal values (not user input) and the values are a tri-state between {True, False, None}. This has been broken from a4f1588 .

@tacaswell
Copy link
Member

Re-ordering all of the tests to check for is None first or switching to an Enum would be "better", but I do not think it is worth the effort.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 1, 2022
@tacaswell
Copy link
Member

I have a minor preference for the commit to include a note about the non-idiomatic code.

@QuLogic QuLogic merged commit a56afb3 into matplotlib:main Aug 3, 2022
@oscargus oscargus deleted the sankeytest branch August 3, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants