-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve mpl_toolkit documentation #23536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0f066c3
to
cc71611
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, haven't commented everywhere, but I think there's no need to do ~.ClassName
, as the ~
trims the displayed name as specified, so there's nothing to trim. It'd only have an effect if you did, e.g., ~.module.ClassName
.
cc71611
to
2321fb7
Compare
e88ef90
to
14b3aaf
Compare
I am a bit confused if one should keep the documentation for |
14b3aaf
to
a7151fe
Compare
I don't think we need extra separation when referencing types in |
Yes.
|
342d48d
to
b95b4ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are code cleanups in here, which makes this require 2 approvals.
b95b4ab
to
c28cccd
Compare
c28cccd
to
88dfcef
Compare
6c09ea0
to
1b4f2f7
Compare
1b4f2f7
to
df6f957
Compare
PR Summary
A bit of links and numpydocifying.
(Probably won't work at the first attempt as I cannot build locally...)
And a minor change in the code for efficiency.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).