Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migrate cibuildwheel workflow to macos-11 #23556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2022
Merged

Migrate cibuildwheel workflow to macos-11 #23556

merged 1 commit into from
Aug 11, 2022

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 4, 2022

PR Summary

The macos-10.15 runner is deprecated:
actions/runner-images#5583

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added Build CI: Run cibuildwheel Run wheel building tests on a PR labels Aug 4, 2022
@QuLogic QuLogic modified the milestones: v3.5.3, v3.5.4 Aug 9, 2022
@QuLogic QuLogic force-pushed the bump-cibuildwheel-mac branch from 8477aac to 0b98aab Compare August 9, 2022 21:40
@QuLogic QuLogic force-pushed the bump-cibuildwheel-mac branch from 0b98aab to 36ff871 Compare August 11, 2022 19:37
@tacaswell tacaswell merged commit ff9f038 into matplotlib:main Aug 11, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Aug 11, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.5.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ff9f038b74963f3458b0627f5f1e13e56a65aaed
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #23556: Migrate cibuildwheel workflow to macos-11'
  1. Push to a named branch:
git push YOURFORK v3.5.x:auto-backport-of-pr-23556-on-v3.5.x
  1. Create a PR against branch v3.5.x, I would have named this PR:

"Backport PR #23556 on branch v3.5.x (Migrate cibuildwheel workflow to macos-11)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@QuLogic QuLogic deleted the bump-cibuildwheel-mac branch August 11, 2022 21:54
@rcomer
Copy link
Member

rcomer commented Dec 10, 2022

Since this was milestoned for v3.5.4, I assume the backport is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
Build CI: Run cibuildwheel Run wheel building tests on a PR
Projects
None yet
Milestone
v3.5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@QuLogic @rcomer @greglucas @tacaswell