re-base of font fallback for pdf and eps output + SVG support #23559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have debugged this to something going wrong in writing the fonts and only one font being embedded in the PDF, but not why yet. |
|
I have now squashed all of @aitikgupta 's work (+ adapting to the new c++ API) into two commits + a c++ commit + 2 extra commits. I think this is ready to review. The c++ needs the most attention. There is likely also some un-needed work in the PDF backend. |
|
Also looks like I accidentally used too-new of c++. |
QuLogic
reviewed
Aug 9, 2022
QuLogic
reviewed
Aug 9, 2022
QuLogic
reviewed
Aug 9, 2022
QuLogic
approved these changes
Aug 9, 2022
QuLogic
approved these changes
Aug 9, 2022
oscargus
reviewed
Aug 10, 2022
oscargus
reviewed
Aug 10, 2022
oscargus
reviewed
Aug 10, 2022
| "family_name, file_name", | ||
| [ | ||
| ("WenQuanYi Zen Hei", "wqy-zenhei.ttc"), | ||
| ("Noto Sans CJK JP", "NotoSansCJK-Regular.ttc"), |
There was a problem hiding this comment.
Not sure I fully get this (probably not), but for OSX the font seems to be NotoSansCJKsc-Regular.otf. Not that it may be required to add that...
There was a problem hiding this comment.
I guess we need to extend this to be a set of possible names?
Co-authored-by: Oscar Gustafsson <[email protected]>
6 tasks
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a rebase of #20804 and ##20832, given that there was not a lot of discussion on either PR, I am making a new PR rather than force-pushing to @aitikgupta 's branches.
My process here was to discard all changes to the c++ code and keep all changes to the Python code from #20804 and then implement the c++ layer needed to make the Python run (with some small changes to the Python + fixing up rebase errors.).
The current status of this:
the pdf test only shows the Chinese characters 😞This was a "re use of names" bug 🎉c++ needs more error checking 😞This could still be better, but the one obvious place that needed it has itget_fontmap🎉the c++ style is terrible 😞acceptable now.