Deprecate get_grid_positions(..., raw=True).
#23572
Conversation
|
I agree we don't use this anymore. OTOH I'm not sure why we would bother deprecating it? |
|
Less functionality and API surface is better from a maintainability and usability point of view. If we don’t have a good reason to keep this - for us or the user, let’s get rid of it. |
|
I guess that is my point - it seems useful to provide a geometrical division of the figure without having to manually set all the subplot_params to zero and then potentially have to restore them. |
|
I don't think I can find anyone using it on GitHub, only forks of us/fully committed venvs. |
|
I don't have a very strong opinion there; my PoV was basically the one expressed by @timhoffm at #23572 (comment). If @jklymak feels strongly about this we can close it too. |
|
@jklymak please speak up if you want to keep this. |
|
I spoke up above - I don't see that this is worth a deprecation song and dance, but if you want it out, I'm not blocking. |
|
Let's let @tacaswell make the call on that one. |
The API was added in f8dfea7 but never actually used anywhere.
The API was added in f8dfea7 (@jklymak) but never actually used anywhere.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).