Editing "issues for new contributors" #23602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Aug 10, 2022
tacaswell
reviewed
Aug 10, 2022
|
I am very 👍🏻 on this modulo those comments. Strongly suspect that rebasing on main will fix the build issue. |
QuLogic
reviewed
Aug 10, 2022
|
Thanks for the useful comments! I will fix it up. 🙇 |
greglucas
approved these changes
Aug 11, 2022
|
Yeah, I imagine this is the reason it was like this before. I am not certain how to distinguish them at this time. |
tacaswell
reviewed
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR edits clarifies the reasons
Difficulty: MediumandDifficulty: Hardlabels might be added.It is based on conversations arising in the new contributor meeting.
Feedback is welcome!
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).