-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Support \underline
in Mathtext.
#23616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Looks good! I think it makes sense to add a brief What's new for this to make users aware that it is added. Also, I think it may be enough to have a "lightweight" test for this as it doesn't seem very dependent on the font: matplotlib/lib/matplotlib/tests/test_mathtext.py Lines 124 to 132 in ecba9d2
|
@anntzer I think you as our TeX expert should review this. |
Sure, l'll need a couple of days though. |
This seems reasonable, but 1) do you know why the overline() implementation is so different, using a fill instead? (which seems inconsistent with the TeXbook); 2) the TeXbook (rules G9/G10 p443) add an extra |
PR Summary
#15624 hasn't seen any activity for a while, so I went ahead with this.
Note that the underline is drawn below the lowest descender. This is consistent with TeX. (The PNG images suffer from what I assume is pixel rounding.)
Fixes #14235.
Closes #15624
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).