Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Doc]: Document the position parameter in apply_aspect() #23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2022

Conversation

haziq-khurshid
Copy link
Contributor

PR Summary

This PR documents the position paramter in apply_aspect()
Issue: #23583

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (and pytest passes).
  • [ N/A] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [ N/A] New features are documented, with examples if plot related.
  • [ N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [ N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@haziq-khurshid
Copy link
Contributor Author

@tacaswell Kindly close the previous PR: #23617
I couldn't update it because I had deleted the branch used to make that PR.
Apologies for any inconvinience.

@tacaswell
Copy link
Member

In the future when you open a PR please only open it once and then push changes to that branch.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 14, 2022
@tacaswell tacaswell merged commit ecba9d2 into matplotlib:main Aug 14, 2022
@tacaswell
Copy link
Member

Thank you for you work on this @haziq-khurshid and congratulations on your first merged Matplotlib PR πŸŽ‰

Hopefully we will hear from you agian!

@haziq-khurshid
Copy link
Contributor Author

Thank you @tacaswell for being helpful.
I'll definitely contribute more often in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants