-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
[DOC]: Add grid to style sheets #23730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers
or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
This is probably an acceptable solution, but you need some way of telling users the one out of six panels is not actually the default. Clearest would likely be to add a small annotation on the plot with the changed default. |
If we want to add a plot with a grid (of which I'm still not convinced that it's necessary)., that'd need to be clearly separated. E.g. by a vertical line. Mockup: This means we have to free one Axes for this illustration. I think the lines should be in the regular part. We might get rid / reuse the colored circles for this. It's not a standard plot and does not really show something new: The color cycling is already present in the lines plot and a scatter-like picture is already included through the |
I was suggesting just annotating the line plots with a |
@timhoffm does this work or we could go with the approach you suggested |
I'm still very skeptical whether adding the grid is an improvement.
I'd rather not go down this road. But if others really want this I suggest something very explicit like: The content of the grid example could be different if you like, I have no strong opinion here. |
@Kinza-Raza sorry this fell off the radar - do you have the bandwidth to follow up on Tim's suggestion? |
@story645 Might take a look at this one? |
That's ok w/ me if you credit @Kinza-Raza as a co-author. |
Feel free to take this up @kostyafarber |
Opened a PR at #24020. |
closed since #24020 went in, but I'm a little iffy if the co-authoring was done properly. Thank you @Kinza-Raza for all the work you did on this! |
@Kinza-Raza Thank you for your work! Sorry if I didn't attribute you properly. |
Is my fault for not aggressively flagging it, but I think we can amend the commit if we get the right name/email combo @QuLogic? |
Why do you think the co-authorship is wrong on the commit? fd5cf5c |
B/c @Kinza-Raza avatar isn't showing up as a co-author so I think that means it's not linking to her account. |
Yeah I made sure to check one of her commits and get the correct email. But she might of changed it since then. Not sure. |
Not sure why my work email showed up. The correct one is [email protected]. |
You may have your work email in your .gitconfig |
PR Summary
This PR adds gridlines for all available style sheets to help visualise the default colour of the grid in each style sheet.
Addresses #23601
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).