Update grammar #23737
Update grammar #23737
Conversation
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you for your effort @Snipeur060 . However I think one of these changes is wrong and the other two are neutral (neither improve nor harm the docs). |
|
i change in recommandation of @jklymak (thx) |
|
if it's good for everyone it's good for me :-) |
|
Can you squash to one commit, or would you like us to do it? |
|
sorry i don't know how :-( |
|
We can do it for you if you prefer, but if you want to try (backup your branch first) https://stackoverflow.com/questions/14534397/squash-all-my-commits-into-one-for-github-pull-request. |
|
i will try |
|
ok i just understand the version where you squash and merge but the other i don't understand |
|
(I prefer that you do) |
|
Thank you for you work on this @Snipeur060 and congratulations on your first merged Matplotlib PR 🎉 . Hope we hear from you again! |
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).