FIX: unbreak ipympl #23742
Merged
FIX: unbreak ipympl #23742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not try to make a toolbar for the classes in backend_webaggcore because ipympl inherits from these classes and requires its own toolbar to be used. This also fixes the webagg embedding example without breaking ipympl. closes matplotlib#23699
|
I can confirm this fixes things for me, thanks for the quick investigation and fix @tacaswell ! |
QuLogic
approved these changes
Aug 26, 2022
greglucas
approved these changes
Aug 27, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Aug 27, 2022
QuLogic
added a commit
that referenced
this pull request
Aug 27, 2022
…742-on-v3.6.x Backport PR #23742 on branch v3.6.x (FIX: unbreak ipympl)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We must not try to make a toolbar for the classes in backend_webaggcore because
ipympl inherits from these classes and requires its own toolbar to be used.
This also fixes the webagg embedding example without breaking ipympl.
closes #23699
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).