Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: Fix num2date docstring #23784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

DOC: Fix num2date docstring #23784

merged 1 commit into from
Aug 31, 2022

Conversation

StefRe
Copy link
Contributor

@StefRe StefRe commented Aug 31, 2022

PR Summary

There is no addition of one anymore.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

There is no addition of one anymore.
@tacaswell
Copy link
Member

When did we remove the extra +1 and do we expect that?

@jklymak
Copy link
Member

jklymak commented Aug 31, 2022

We changed the epoch to the unix epoch. One can easily get the +1 behaviour agin if you want ;-)

@StefRe
Copy link
Contributor Author

StefRe commented Aug 31, 2022

When did we remove the extra +1?

in version 3.3.0 with a3fbc49

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 31, 2022
@oscargus oscargus merged commit dd7cf3a into matplotlib:main Aug 31, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 31, 2022
QuLogic added a commit that referenced this pull request Aug 31, 2022
…784-on-v3.6.x

Backport PR #23784 on branch v3.6.x (DOC: Fix num2date docstring)
@StefRe StefRe deleted the patch-1 branch September 1, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants