Fix cross-compiling internal freetype #23852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing BUILD_GNU_TYPE as the host, it should be HOST_GNU_TYPE. This fixes cross-compilation for osx_arm64 on conda-forge.
|
I wouldn't mind this getting into 3.6, but I already have the patch working so it's not a huge deal either. |
QuLogic
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
This looks correct. I don't think I had any reason to pick BUILD_GNU_TYPE over HOST_GNU_TYPE; I think it was just the first one to pop out to me as useful from sysconfig.get_config_vars.
From the original commit 76f1516, you can see I never was able to properly test this given where we thought it would have an effect.
timhoffm
approved these changes
Sep 10, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 10, 2022
timhoffm
pushed a commit
that referenced
this pull request
Sep 10, 2022
Co-authored-by: Ryan May <[email protected]>
dcamron
added a commit
to dcamron/MetPy
that referenced
this pull request
Sep 21, 2022
With matplotlib/matplotlib#23852 and conda-forge/matplotlib-feedstock#329, we can now run image tests on osx-arm64 platforms with a testing install of Matplotlib. There are some artifacts across architecture. Burying these in test tolerance allows tests to pass in a fully osx-arm64 environment. Ideally to be reduced in the future.
dcamron
added a commit
to dcamron/MetPy
that referenced
this pull request
Sep 21, 2022
With matplotlib/matplotlib#23852 and conda-forge/matplotlib-feedstock#329, we can now run image tests on osx-arm64 platforms with a testing install of Matplotlib. There are some artifacts across architecture. Burying these in test tolerance allows tests to pass in a fully osx-arm64 environment. Ideally to be reduced in the future.
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Dec 19, 2022
Instead of passing BUILD_GNU_TYPE as the host, it should be HOST_GNU_TYPE. This fixes cross-compilation for osx_arm64 on conda-forge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Instead of passing
BUILD_GNU_TYPEas the host, it should beHOST_GNU_TYPE. This fixes cross-compilation for osx_arm64 on conda-forge. See conda-forge/matplotlib-feedstock#329.I wasn't able to find any quick documentation for these keys, but this discussion post is what clued me in. @QuLogic did you have something else that led you to use
BUILD_GNU_TYPEwhen you added it originally?PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).